edit

Contributing

This is a guide to contributing to Plots and the surrounding ecosystem. Plots is a complex and far-reaching suite of software components, and as such will be most effective when the community contributes their own expertise, knowledge, perspective, and effort. The document is roughly broken up into the following categories, and after reading this introduction you should feel comfortable skipping to the section(s) that interest you the most:

When in doubt, use this handy dandy logic designed by a legendary open source guru...


The JuliaPlots Organization

JuliaPlots is the home for all things Plots. It was founded by Tom Breloff, and extended through many contributions from members and others. The first step in contributing will be to understand which package(s) are appropriate destinations for your code.

Plots

This is the core package for:

  • Definitions of plot/plot!
  • The core processing pipeline
  • Base recipes for path, scatter, bar, and many others
  • Generic output methods
  • Generic layout methods
  • Generic animation methods
  • Generic types: Plot, Subplot, Axis, Series, ...
  • Conveniences: getindex/setindex, push!/append!, unzip, cycle, ...

This package depends on RecipesBase, PlotUtils, and PlotThemes. When contributing new functionality/features, you should make best efforts to find a more appropriate home (StatPlots, PlotUtils, etc) than contributing to core Plots. In general, the push has been to reduce the size and scope of Plots, when possible, and move features to other packages.

Backends

In Julia versions v0.5 and earlier, backend code (such as code linking Plots with GR) lived in the Plots/src/backends directory. As such, backend code should be contributed to core Plots.

Starting with v0.6, the backend code will live in separate repos, and loaded on demand. For example, the GR backend is being developed at PlotsGR. Users targeting v0.6 and later should contribute to the respective backend package "Plots[backend].jl".

Note: As of 2/22/17, the reorg branch of Plots is needed for compatibility with the new backend repos. This will be merged into the master branch sometime after the release of v0.6.

This redesign will help with improved support for precompilation, and a cleaner separation of "generic plotting" development and "backend-specific" development.

PlotDocs

PlotDocs is the home of this documentation. The documentation is built using the "material" theme in "mkdocs". For those contributing documentation (to the docs directory of PlotDocs), it must be subsequently built and deployed using the following instructions:

# Note: the site is built inside the PlotDocs.jl repo, but then deployed to the JuliaPlots organization page

# To build, run from inside the PlotDocs directory:
#     mkdocs build --clean
# (optional) Make the githubio remote point to JuliaPlots/juliaplots.github.io:
#     git remote add githubio git@github.com:JuliaPlots/juliaplots.github.io.git
# Add files, commit, then push:
#     git push origin master
# Push just the site directory to the master branch of githubio
#     git subtree push --prefix site githubio master

RecipesBase

Seldom updated, but essential. This is the package that you would depend on to create third-party recipes. It contains the bare minimum to define new recipes.

PlotUtils

Components that could be used for other (non-Plots) packages. Anything that is sufficiently generic and useful could be contributed here.

  • Color (conversions, construction, conveniences)
  • Color gradients/maps
  • Tick computation

PlotThemes

Visual themes (i.e. attribute defaults) such as "dark", "orange", etc.

StatPlots

An extension of Plots: Statistical plotting and tabular data. Complex histograms and densities, correlation plots, and support for DataFrames. Anything related to stats or special handling for table-like data should live here.

PlotRecipes

An extension of StatPlots: Graphs, maps, and more. If it's not a "base recipe", and also not clearly "statistical" in nature, then this package might be a good home.

MLPlots

An extension of PlotRecipes, geared toward Machine Learning applications: neural nets, spike trains, ROC curves, and more.

GGPlots

A prototype API/interface for "Grammar of Graphics" style plotting. This likely wouldn't add actual functionality, but would give users coming from R/ggplot2 a simple way to avoid Gadfly. I (Tom) wrote the prototype to show how easy it is, but since I dislike GoG-style, I never finished it. Completing this package would be a great self-contained project for interested parties.


Choosing a Project

For people new to Plots, the first step should be to read (and reread) the documentation. Code up some examples, play with the attributes, and try out multiple backends. It's really hard to contribute to a project that you don't know how to use.

Beginner Project Ideas

  • Create a new recipe: Preferably something you care about. Maybe you want custom overlays of heatmaps and scatters? Maybe you have an input format that isn't currently supported? Make a recipe for it so you can just plot(thing).
  • Fix bugs: There are many "bugs" which are specific to one backend, or incorrectly implement features that are infrequently used. Some ideas can be found in the issues marked easy.
  • Add recipes to external packages: By depending on RecipesBase, a package can define a recipe for their custom types. Submit a PR to a package you care about that adds a recipe for that package. For example, see this PR to add OHLC plots for TimeSeries.jl.

Intermediate Project Ideas

  • Improve your favorite backend: There are many missing features and other improvements that can be made to individual backends. Most issues specific to a backend have a special tag.
  • Help with documentation: This could come in the form of improved descriptions, additional examples, or full tutorials. Please contribute improvements to PlotDocs.
  • Help with the v0.6 reorganization: The reorg requires the annoying effort of creating new repos (PlotsPyPlot, PlotsPlotlyJS, etc) that hold the backend code. I consider this intermediate because you need to know a little about Plots and git, but it's fairly straightforward to follow the model of PlotsGR.
  • Expand StatPlots functionality: qqplot, DataStreams, or anything else you can think of.

Advanced Project Ideas

  • ColorBar redesign: Colorbars need serious love... this would likely require a new Colorbar type that links with the appropriate Series object(s) and is independent during subplot layout. We want to allow many series (possibly from multiple subplots) to use the same clims and to share a colorbar, or have multiple colorbars that can be flexibly positioned.
  • PlotSpec redesign: This long standing redesign proposal could allow generic serialization/deserialization of Plot data and attributes, as well as some improvements/optimizations when mutating plots. For example, we could lazily compute attribute values, and intelligently flag them as "dirty" when they change, allowing backends to skip much of the wasted processing and unnecessary rebuilding that currently occurs.
  • Improve graph recipes: Lots to do here: clean up visuals, improve edge drawing, implement layout algorithms, and much more.

Key Design Principles

Flexible and generic... these are the core principles underlying Plots development, and also tend to cause confusion when users laser-focus on their specific use case.

I (Tom) have painstakingly designed the core logic to support nearly any use case that exists or may exist. I don't pretend to know how you want to use Plots, or what type of data you might pass in, or what sort of recipe you may want to apply. As such, I try to avoid unnecessary restriction of types, or forced conversions, or many other pitfalls of limited visualization frameworks. The result is a highly modular framework which is limited by your imagination.

When contributing new features to Plots (or the surrounding ecosystem), you should strive for this mentality as well. New features should be left as generic as possible, while avoiding obvious feature clash.

As an example, you may want a new recipe that shows a histogram when passed Float64 numbers, but shows counts of every unique value for strings. So you make a recipe that works perfectly for your purpose:

using Plots, StatsBase
gr(size=(300,300), leg=false)

@userplot MyCount
@recipe function f(mc::MyCount)
    # get the array from the args field
    arr = mc.args[1]

    T = typeof(arr)
    if T.parameters[1] == Float64
        seriestype := :histogram
        arr
    else
        seriestype := :bar
        cm = countmap(arr)
        x = sort!(collect(keys(cm)))
        y = [cm[xi] for xi=x]
        x, y
    end
end

The recipe defined above is a "user recipe", which builds a histogram for arrays of Float64, and otherwise shows a "countmap" of sorted unique values and their observed counts. You only care about Float64 and String, and so you're results are fine:

mycount(rand(500))

mycount(rand(["A","B","C"],100))

But you didn't consider the person that, in the future, might want to pass integers to this recipe:

mycount(rand(1:500, 500))

This user expected integers to be treated as numbers and output a histogram, but instead they were treated like strings. A simple solution would have been to replace if T.parameters[1] == Float64 with if T.parameters[1] <: Number. However, should we even depend on T having it's first parameter be the element type? (No) So even better would be if eltype(arr) <: Number, which now allows any container with any numeric type to trigger the "histogram" logic.

This simple example outlines a common theme when developing Plots (or really any other Julia package). Try to create the most generic implementation you can think of while maintaining correctness. You don't know what crazy types someone else will use to try to access your functionality.


Code Organization

Generally speaking, similar functionality is kept within the same file. Within the src directory, much of the files should be self explanatory (for example, you'll find animation methods/macros in the animation.jl file), but some could use a summary of contents:

  • Plots.jl: imports, exports, shorthands, and initialization
  • args.jl: defaults, aliases, and attribute processing
  • components.jl: shapes, fonts, and other assorted goodies
  • pipeline.jl: code which builds the plots and subplots through recursive application of recipes
  • recipes.jl: primarily core series recipes
  • series.jl: core input data handling and processing
  • utils.jl: lots of functionality that didn't have a home... getindex/setindex! for Plot/Subplot/Axis/Series, push!/append! for adding data to a series, cycle/unzip and similar utility functions, Segments/SegmentsIterator, etc.

These files should probably be reorganized, but until then...

Creating new backends

Model new backends on PlotsGR. Implement the callbacks that are appropriate, especially _display and _show for GUI and image output respectively.

Style/Design Guidelines

  • Make every effort to minimize external dependencies and exports. Requiring new dependencies is the most likely way to make your PR "unmergeable".
  • Be careful adding method signatures on existing methods with Base types (Array, etc) as you may override key functionality. This is especially true with recipes. Consider wrapping inputs in a new type (like in "user recipes").
  • Terse code is ok, as is verbose code. What's important is understanding and context. Will someone reading your code know what you mean? If not, consider writing comments to describe your reason for the design, or describe the hack you just implemented in clear prose. Sometimes it's ok that your comments are longer than your code.
  • Pick your project for yourself, but write code for others. It should be generic and useful beyond your needs, and you should never break functionality because you can't figure out how to implement something well. Spend more time on it... there's always a better way.

Git-fu (or... the mechanics of contributing)

Many people have trouble with Git. More have trouble with Github. I think much of the confusion happens when you run commands without understanding what they do. We're all guilty of it, but recovering usually means "starting over". In this section, I'll try to keep a simple, practical approach to making PRs. It's worked well for me, though YMMV.

Guidelines

Here are some guidelines for the development workflow (Note: Even if you've made 20 PRs to Plots in the past, please read this as it may be different than past guidelines):

  • Commit to a branch that belongs to you. Typically that means you should give your branches names that are unique to you, and that might include information on the feature you're developing. For example, I might choose to git checkout -b tb-fonts when starting work on fonts.
  • Open a PR against master. master is the "bleeding edge". (Note: I used to recommend PRing to dev)
  • Only merge others changes when absolutely necessary. You should prefer to use git rebase origin/master instead of git merge origin/master. A rebase replays your recent commits on top of the most recent master, avoiding complicated and messy merge commits and generally avoiding confusion. If you follow the first rule, then you likely won't get yourself in trouble. Rebase horror stories generally result when many people are working on the same branch. I find this resource is great for understanding the important parts of git rebase.

Development Workflow

My suggestions for a smooth development workflow:

Fork the repo

Navigate to the repo site (https://github.com/JuliaPlots/Plots.jl) and click the "Fork" button. You might get a choice of which account or organization to place the fork. I'll assume going forward that you forked to Github username user123.

Set up the git remote

Navigate to the local repo. Note: I'm assuming that you do development in your Julia directory, and using Mac/Linux. Adjust as needed.

cd ~/.julia/v0.5/Plots
git remote add forked git@github.com:user123/Plots.jl.git

After running these commands, git remote -v should show two remotes: origin (the main repo) and forked (your fork). A remote is simply a reference/pointer to the github site hosting the repo, and a fork is simply any other git repo with a special link to the originating repo.

Create a new branch

If you're just starting work on a new feature:

git fetch origin
git checkout master
git merge --ff-only origin/master
git checkout -b user123-myfeature
git push -u forked user123-myfeature

The first three lines are meant to ensure you start from the main repo's master branch. The --ff-only flag ensures you will only "fast forward" to newer commits, and avoids creating a new merge commit when you didn't mean to. The git checkout line both creates a new branch (the -b) pointing to the current commit and makes that branch current. The git push line adds this branch to your Github fork, and sets up the local branch to "track" (-u) the remote branch for subsequent git push and git pull calls.

or... Reuse an old branch

If you have an ongoing development branch (say, user123-dev) which you'd prefer to use (and which has previously been merged into master!) then you can get that up to date with:

git fetch origin
git checkout user123-dev
git merge --ff-only origin/master
git push forked user123-dev

We update our local copy of origin, checkout the dev branch, then attempt to "fast-forward" to the current master. If successful, we push the branch back to our forked repo.

Write code and commit

After powering up your favorite editor (maybe Juno?) and making some code changes to the repo, you'll want to "commit" or save a snapshot of all the changes you made. After committing, you can "push" those changes to your forked repo on Github:

git add src/my_new_file.jl
git commit -am "my commit message"
git push forked user123-dev

The first line is optional, and is used when adding new files to the repo. The -a means "commit all my changes", and the -m lets you write a note about the commit (you should always do this, and hopefully make it descriptive).

Submit a PR

You're almost there! Browse to your fork (https://github.com/user123/Plots.jl). Most likely there will be a section just above the code that asks if you'd like to create a PR from the user123-dev branch. If not, you can click the "New pull request" button.

Make sure the "base" branch is JuliaPlots master and the "compare" branch is user123-dev. Add an informative title and description, and link to relevant issues or discussions, then click "Create pull request". You may get some questions about it, and possibly suggestions of how to fix it to be "merge-ready". Then hopefully it gets merged... thanks for the contribution!!

Cleanup

After all of this, you will likely want to go back to using master (or possibly using a tagged release, once your feature is tagged). To clean up:

git fetch origin
git checkout master
git merge --ff-only origin/master
git branch -d user123-dev

This catches your local master branch up to the remote master branch, then deletes the dev branch. If you want to return to tagged releases, run Pkg.free("Plots") from the Julia REPL.


Tags

New tags should represent "stable releases"... those that you are happy to distribute to end-users. Effort should be made to ensure tests pass before creating a new tag, and ideally new tests would be added which test your new functionality. This is, of course, a much trickier problem for visualization libraries as compared to other software. See the testing section below.

Only JuliaPlots members may create a new tag. To create a new tag, we'll create a new release on Github and use attobot to generate the PR to METADATA. Create a new release at https://github.com/JuliaPlots/Plots.jl/releases/new (of course replacing the repo name with the package you're tagging).

The version number (vMAJOR.MINOR.PATCH) should be incremented using semver, which generally means that breaking changes should increment the major number, backwards compatible changes should increment the minor number, and bug fixes should increment the patch number. For "v0.x.y" versions, this requirement is relaxed. The minor version can be incremented for breaking changes.


Testing

VisualRegressionTests

Testing in Plots is done with the help of VisualRegressionTests. Reference images are stored in PlotReferenceImages. Sometimes the reference images need to be updated (if features change, or if the underlying backend changes). VisualRegressionTests makes it somewhat painless to update the reference images:

From the Julia REPL, run include(Pkg.dir("Plots","test","runtests.jl")). This will try to plot the tests, and then compare the results to the stored reference images. If the test output is sufficiently different than the reference output (using Tim Holy's excellent algorithm for the comparison), then a GTK window will pop up with a side-by-side comparison. You can choose to replace the reference image, or not, depending on whether a real error was discovered.

After the reference images have been updated, navigate to PlotReferenceImages and push the changes to Github:

cd ~/.julia/v0.5/PlotReferenceImages
git add Plots/*
git commit -am "a useful message"
git push

If there are mis-matches due to bugs, don't update the reference image.

Travis

On a git push, Travis tests will be triggered. This runs the same tests as above, downloading and comparing to the reference images, though with a larger tolerance for differences. When Travis errors, it may be due to timeouts, stale reference images, or a host of other reasons. Check the Travis logs to determine the reason. If the tests are broken because of a new commit, consider rolling back.